[enable_counters.py] Convert to Python 3#5789
Merged
lguohan merged 2 commits intosonic-net:masterfrom Nov 6, 2020
jleveque:enable_counters_py3
Merged
[enable_counters.py] Convert to Python 3#5789lguohan merged 2 commits intosonic-net:masterfrom jleveque:enable_counters_py3
lguohan merged 2 commits intosonic-net:masterfrom
jleveque:enable_counters_py3
Conversation
Contributor
Author
|
Retest vsimage please |
qiluo-msft
reviewed
Nov 6, 2020
pavel-shirshov
approved these changes
Nov 6, 2020
qiluo-msft
approved these changes
Nov 6, 2020
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
**- Why I did it** As part of moving all SONiC code from Python 2 (no longer supported) to Python 3 **- How I did it** - Convert enable_counters.py script to Python 3 - Reorganize imports per PEP8 standard - Two blank lines precede functions per PEP8 standard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
- Why I did it
As part of moving all SONiC code from Python 2 (no longer supported) to Python 3
- How I did it
- How to verify it
Ensure enable_counters.py script still functions correctly
- Which release branch to backport (provide reason below if selected)